feat(dblint): add pglinter - #632
Merged
Merged
Conversation
psteinroe
marked this pull request as draft
December 29, 2025 12:49
psteinroe
force-pushed
the
feat/splinter
branch
from
December 29, 2025 15:09
ce64a8b to
322df77
Compare
psteinroe
marked this pull request as ready for review
December 30, 2025 10:26
juleswritescode
approved these changes
Jan 9, 2026
|
|
||
| # Verify installation | ||
| echo "Extension control files:" | ||
| ls -la "$(pg_config --sharedir)/extension/" | grep pglinter || echo "No pglinter found" |
Collaborator
There was a problem hiding this comment.
should we fail early here? right now this would be cachted after creating extension plpgsql_check, if I'm not mistaken
| let mut runnable_rules = Vec::new(); | ||
| for rule_code in &enabled_rules { | ||
| if disabled_in_extension.contains(rule_code) { | ||
| results.push(PglinterDiagnostic::rule_disabled_in_extension(rule_code)); |
psteinroe
force-pushed
the
feat/dblint
branch
from
January 11, 2026 14:43
e751450 to
0ad9efe
Compare
psteinroe
force-pushed
the
feat/splinter
branch
from
January 11, 2026 15:01
3cf1119 to
a2e542e
Compare
psteinroe
force-pushed
the
feat/splinter
branch
3 times, most recently
from
February 3, 2026 15:14
21d62aa to
600baf6
Compare
- Add #![cfg(not(target_os = "windows"))] to skip pglinter tests on Windows since the pglinter extension is not available there (only Linux/macOS) - Fix clippy warnings: use as_deref() and contains() instead of manual patterns - Remove table_with_primary_key test since pglinter checks all tables globally, making a "no diagnostics for table with PK" test impossible when other tables exist - Add plpgsql_check as dependency in test setup 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add RuleMessage struct to fetch messages from pglinter.rule_messages table
- Update PglinterCache to store rule_messages HashMap
- Update from_violation() to use dynamic messages with {object} placeholder
- Fall back to hardcoded messages for older pglinter versions
- Add feature gates to indexes.rs and sequences.rs for WASM compatibility
psteinroe
force-pushed
the
feat/splinter
branch
from
February 3, 2026 15:28
600baf6 to
ea6ecd2
Compare
Update lockfile to resolve windows-sys and json-strip-comments dependencies. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ization Allow partial JSON schemas to be deserialized by defaulting missing fields to empty vectors. This fixes WASM tests that don't provide all schema fields. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Switch from the development branch to main which now includes the get_violations API and rule_messages table (v1.1.0+). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
psteinroe
force-pushed
the
feat/splinter
branch
from
February 5, 2026 08:17
47764b1 to
e59a28e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds support for
pglinterand integrate it withdblint. It reuses the existing infrastructure, and 99% of the code changes are generated.adapted the
Dockerfileto also installpglinter. Will take around 10 minutes now to build, but its all cached after that.the initial metadata is generated from the downloaded repo. a follow-up pr will automate this too.
pglinter works in a weird way where the user defines thresholds for certain rules. e.g.
I would much rather see the actual objects that have an uppercase in name...
Opened an issue to check in with the maintainer: pmpetit/pglinter#83